Skip to content

Scrollbar fixes#873

Merged
pomianowski merged 5 commits intolepoco:developmentfrom
niels9001:niels9001/scrollbar-fix
Dec 12, 2023
Merged

Scrollbar fixes#873
pomianowski merged 5 commits intolepoco:developmentfrom
niels9001:niels9001/scrollbar-fix

Conversation

@niels9001
Copy link
Copy Markdown
Contributor

@niels9001 niels9001 commented Dec 11, 2023

Updated the (Dynamic)ScrollBar default style to be more inline with WinUI addressing: #872

  • Added on hover background color (couldn't use InAppAcrylicDefaultBrush like in WinUI, but used the replacement color we also use for e.g. Flyout)
  • Decreased scrollbar thumb width based on WinUI spec
  • Decreased icon fontsize so it's centered and inline with WinUI spec

Before:
image

After:
image

ScrollBar now overlaps content, addressing: #871

  • Tweaked the default ScrollViewer style so it overlaps its content
  • Set a default style for PassiveScrollViewer so it uses the ScrollViewer style as well (as ListView uses PassiveScrollViewer)
    Before:
    image

After:
image

@niels9001
Copy link
Copy Markdown
Contributor Author

@pomianowski In case this PR gets approved, would you mind creating a Preview.13 :)?

@pomianowski pomianowski merged commit 54a4d52 into lepoco:development Dec 12, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants