Skip to content

[Run] UI improvements + ability to show/hide plugins overview panel#30258

Merged
niels9001 merged 15 commits intomainfrom
niels9001/run-ui-fixes
Dec 19, 2023
Merged

[Run] UI improvements + ability to show/hide plugins overview panel#30258
niels9001 merged 15 commits intomainfrom
niels9001/run-ui-fixes

Conversation

@niels9001
Copy link
Copy Markdown
Collaborator

@niels9001 niels9001 commented Dec 7, 2023

This PR addresses #30200, #30168 (partially), and introduces the following changes:

Design tweaks to address community feedback:

  • Removed searchbox border
  • Increased fontsizes
  • Increased spacing between results
  • Increased the color ratio between title + path in dark mode
  • Slight adjustments to the selection visual: the selected background color is slightly more intense and the selection pill is now taller
  • Other minor tweaks
    Run tweaks

Setting to hide/show the plugins overview whenever the search textbox is empty

A new setting has been added under "Position & appearance" allowing to show or hide the plugins overview when the searchbox is empty

image

Result:
image

Updated the tooltip so it can stretch wider to show more content, removed redundant prefixes in Program plugin ("Name" + "Path" labels).**

Before vs. after
image

Fixed a bug where no visible gap was shown for image thumbnails

Before vs. after
image

Fixed a bug where a long plugin keyword would centered becoming unreadable

Before:
image

After: a tooltip has been added
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@niels9001 niels9001 added the Hot Fix Items we will product an out-of-band release for label Dec 7, 2023
@niels9001 niels9001 requested a review from stefansjfw December 7, 2023 15:39
@niels9001 niels9001 removed the Hot Fix Items we will product an out-of-band release for label Dec 7, 2023
Comment thread src/modules/launcher/PowerLauncher/MainWindow.xaml Outdated
Comment thread src/modules/launcher/PowerLauncher/MainWindow.xaml Outdated
Copy link
Copy Markdown
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's watch symmetry :)
  • By comment in #30200: There is more then one way to hide the tips, let's see what is preferred

@Jay-o-Way

This comment has been minimized.

@Jay-o-Way
Copy link
Copy Markdown
Collaborator

Question: Is it possible to remove the TextBlock out of the ToolTips? I think it is responsible for:
Schermafbeelding 2023-12-07 175430

<Grid.ToolTip>
<ToolTip Opened="ToolTip_Opened" Visibility="{Binding Result.ToolTipVisibility}">
<StackPanel>
<TextBlock
FontWeight="Bold"
Style="{DynamicResource CollapsableTextblock}"
Text="{Binding Result.ToolTipData.Title}"
TextWrapping="Wrap" />
<TextBlock
Margin="0,4,0,0"
Foreground="{DynamicResource TextFillColorSecondaryBrush}"
Style="{DynamicResource CollapsableTextblock}"
Text="{Binding Result.ToolTipData.Text}"
TextWrapping="Wrap" />
</StackPanel>
</ToolTip>
</Grid.ToolTip>

and
<ToolTipService.ToolTip>
<ToolTip Opened="ToolTip_Opened">
<TextBlock
AutomationProperties.Name="{x:Static p:Resources.ContextMenuItemAdditionalInformation}"
Foreground="{DynamicResource TextFillColorPrimaryBrush}"
Text="{Binding Title}" />
</ToolTip>
</ToolTipService.ToolTip>

@htcfreek

This comment has been minimized.

@davidegiacometti
Copy link
Copy Markdown
Collaborator

Nit: TAB key is eaten by results/actions navigation, but when the plugins overview is showed the user should be able to tab into the list and scroll with arrows.

Should be an easy fix but we can address it in another PR.

@UnnaturalTwilight
Copy link
Copy Markdown

An idea for the plugin hints is to have 3 options: all, not included in global results, none
I don't need to be told the shortcut to a plugin that I will get results for anyways without the shortcut

Comment thread src/modules/launcher/PowerLauncher/MainWindow.xaml Outdated
@niels9001
Copy link
Copy Markdown
Collaborator Author

Small detail - the arrow seems to be one or two pixels out of the window, versus the actual scroll bar: image

Being addressed in: lepoco/wpfui#873. So updating to the next preview should fix this :)! Thanks for reporting!

Comment thread src/modules/launcher/PowerLauncher/Styles/Styles.xaml Fixed
Comment thread src/modules/launcher/PowerLauncher/Styles/Styles.xaml Fixed
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@KSaiAkshit
Copy link
Copy Markdown

Would it be possible to make the size adjustable? The new one feels very small on my monitor. The ability to remove plugin suggestions is also nice!

@stefansjfw
Copy link
Copy Markdown
Contributor

An idea for the plugin hints is to have 3 options: all, not included in global results, none I don't need to be told the shortcut to a plugin that I will get results for anyways without the shortcut

Added

@stefansjfw
Copy link
Copy Markdown
Contributor

Nit: TAB key is eaten by results/actions navigation, but when the plugins overview is showed the user should be able to tab into the list and scroll with arrows.

Should be an easy fix but we can address it in another PR.

Good point. Let's do this as a follow-up

Comment thread src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Fixed
Comment thread src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Fixed
@stefansjfw
Copy link
Copy Markdown
Contributor

@niels9001 I added an option to show preview only for non-global plugins. Please double-check phrasing there before merging. Other than that , your changes look good. Nice work!

@microsoft microsoft deleted a comment from github-actions Bot Dec 15, 2023
@niels9001
Copy link
Copy Markdown
Collaborator Author

@niels9001 I added an option to show preview only for non-global plugins. Please double-check phrasing there before merging. Other than that , your changes look good. Nice work!

I think those look pretty good!

@niels9001 niels9001 merged commit af09973 into main Dec 19, 2023
@niels9001 niels9001 deleted the niels9001/run-ui-fixes branch December 19, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants