Fix missing Arc in middleware

[leynos]

Summary

• import Arc for middleware
• fix doctest examples returning ServiceResponse

Testing

• make fmt
• make lint
• make test

---

https://chatgpt.com/codex/tasks/task_e_68554da446088322bc0e956d14d3b549

Summary by Sourcery

Fix missing Arc import in middleware and correct doctest examples to return ServiceResponse::default()

Bug Fixes:

• Import Arc in middleware for proper shared ownership
• Fix doctest examples to return ServiceResponse::default() instead of ServiceResponse

Tests:

• Update inline doctests to use ServiceResponse::default()

Summary by CodeRabbit

• Documentation
  • Updated documentation examples to use the correct return value in code snippets.

[sourcery-ai]

Reviewer's Guide

Imported the missing Arc type into the middleware module and updated the doctest examples to construct ServiceResponse via its default() method so that the examples compile.

Class diagram for ServiceResponse doctest update

classDiagram
    class ServiceResponse {
        +default() ServiceResponse
    }
    class MyService {
        +call(req: ServiceRequest): Result<ServiceResponse, Error>
    }
    MyService --> ServiceResponse : returns

Loading

File-Level Changes

Change	Details	Files
Import Arc for middleware	Add use std::sync::Arc to middleware module imports	src/middleware.rs
Fix doctest examples to use ServiceResponse::default()	Replace Ok(ServiceResponse) with Ok(ServiceResponse::default()) in doc comments of two examples	src/middleware.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Walkthrough

This update introduces an import of std::sync::Arc in the middleware module and revises documentation examples to return Ok(ServiceResponse::default()) instead of Ok(ServiceResponse). These changes are limited to documentation comments and imports, with no modifications to public interfaces or functional logic.

Changes

File(s)	Change Summary
src/middleware.rs	Added Arc import; updated documentation examples to return Ok(ServiceResponse::default()).

Possibly related PRs

• Fix doc examples and remove duplicate tests #25: Updates documentation examples and imports in src/middleware.rs, similar to the current PR.
• Implement functional middleware builder #82: Implements core middleware builder functionality in src/middleware.rs, directly related to the examples updated here.
• Fix compile errors and clippy #11: Modifies the implementation and visibility of methods in middleware.rs, while this PR updates related documentation examples.

Poem

In the code fields where Arc now grows,
Middleware rabbits tweak what shows.
Docs now return a default response,
Clearer examples for those who ensconce.
With every hop, the comments improve—
A gentle update, in the docs we move!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 731daea and 6459a02.

📒 Files selected for processing (1)

• src/middleware.rs (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build-test
• GitHub Check: Analyze (actions)

🔇 Additional comments (3)

src/middleware.rs (3)

7-7: Add missing Arc import for middleware.

This import is required for the FnService struct’s f: Arc<F> field.

---

83-83: Correct doctest example to return default instance.

Updating Ok(ServiceResponse) to Ok(ServiceResponse::default()) ensures the example compiles and uses the Default impl.

---

168-168: Fix return in documentation example for from_fn.

Switching to Ok(ServiceResponse::default()) aligns the sample with the actual API and makes it valid Rust.

✨ Finishing Touches

• 📝 Docstrings were successfully generated. (🔄 Check again to generate docstrings again)- [ ] Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch codex/fix-undeclared-type--arc--in-middleware.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @leynos - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[coderabbitai]

Caution

No docstrings were generated.