Skip to content

Conversation

@cbandy
Copy link
Contributor

@cbandy cbandy commented Mar 15, 2015

Because driver.Value is implemented as an interface{}, its value can actually be any type. It is the responsibility of the sql and driver packages to emit only a few types for these values.

This test ensures those packages are fulfilling their contract in cases we care about.

@johto
Copy link
Contributor

johto commented Mar 16, 2015

What was the conclusion with the float32 handling in encode()? Is it dead code?

@cbandy
Copy link
Contributor Author

cbandy commented Mar 16, 2015

Yes, it's dead.

@cbandy
Copy link
Contributor Author

cbandy commented Apr 2, 2015

@johto would you like me to include a commit that removes the dead code?

@johto
Copy link
Contributor

johto commented Apr 4, 2015

@cbandy: Please do.

@cbandy
Copy link
Contributor Author

cbandy commented Apr 4, 2015

I've added a commit that removes code for encoding float32 values. The tests for #196, #197, and #198 remain and pass.

@johto
Copy link
Contributor

johto commented Apr 8, 2015

I've added a commit that removes code for encoding float32 values. The tests for #196, #197, and #198 remain and pass.

Thanks! I'll try and have a look at this later today.

@cbandy
Copy link
Contributor Author

cbandy commented Apr 22, 2015

@johto I think this (or a test like this) is still valuable to include in our suite. What would you like me to do with this PR?

@johto
Copy link
Contributor

johto commented Apr 22, 2015

@johto I think this (or a test like this) is still valuable to include in our suite. What would you like me to do with this PR?

I agree, but I haven't had a chance to review it yet. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants