F/implement new landing #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2023
Collaborator
Author
|
This need to be tested on hardware with new and old versions of OWRT |
selankon
commented
Feb 8, 2024
Collaborator
Author
selankon
left a comment
selankon
left a comment
There was a problem hiding this comment.
Things to fix, doing my own code review
selankon
force-pushed
the
develop
branch
13 times, most recently
from
c749df1 to
cab8e8d
Compare
selankon
force-pushed
the
f/implement_new_landing
branch
4 times, most recently
from
9cad758 to
d4de192
Compare
selankon
force-pushed
the
f/implement_new_landing
branch
2 times, most recently
from
cc5ecb5 to
74d40f0
Compare
selankon
force-pushed
the
f/implement_new_landing
branch
2 times, most recently
from
19776ed to
d71eb5c
Compare
After rebase develop some changes where missing
selankon
force-pushed
the
f/implement_new_landing
branch
from
6eaf7ec to
55d3e24
Compare
selankon
added a commit
that referenced
this pull request
May 9, 2024
Implement new landing page with - last internet path and internet status - Most active iface - Eth ports usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation for the new landing go together with some lime-packages improvements, ex:
(maybe more that I don't remember, but anyway all are already merged).
Some todos: