Skip to content

Conversation

@dangowrt
Copy link
Contributor

@dangowrt dangowrt commented Jun 2, 2020

conditional dependencies are deprecated. create hard dependency instead as it seems the only good solution.

conditional dependencies are deprecated. create hard dependency
instead as it seems the only good solution.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
@codecov-commenter
Copy link

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files          32       32           
  Lines        2504     2504           
=======================================
  Hits         1836     1836           
  Misses        668      668           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4937ad...08ed272. Read the comment docs.

@dangowrt
Copy link
Contributor Author

dangowrt commented Jun 2, 2020

Only saw #673 now, guess it should be merged with that.

@ilario ilario merged commit 658cd27 into libremesh:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants