-
Notifications
You must be signed in to change notification settings - Fork 110
Remove all conditional dependencies #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I do not agree with this changes, chef and image builder should eventually solve their limitation instead. Also something like chef could be programmed on top of the buildroot instead, which have lot mroe advantages and much less bugs that imagebuilder and similar... |
History is cyclic, they say. In august I commented #558 (comment)
and your comment means that we'll have the lime-build again!!!!! |
Maybe GuifiPedro's TEMBA with this example could be used as the new lime-build? @G10h4ck |
|
In this PR I removed also batctl from lime-debug: |
|
I removed the commit about lime-proto-bmx6 which is better addressed in #716. |
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 73.90% 73.90%
=======================================
Files 34 34
Lines 2817 2817
=======================================
Hits 2082 2082
Misses 735 735 Continue to review full report at Codecov.
|
|
The following conditional dependencies are addressed in this PR.
|
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 73.62% 73.62%
=======================================
Files 35 35
Lines 2972 2972
=======================================
Hits 2188 2188
Misses 784 784 Continue to review full report at Codecov.
|
As reported by @dangowrt in #331, the conditional dependencies work only when compiling using the buildroot method (which is currently the recommended one, see https://libremesh.org/development.html) but not with methods employing the imagebuilder, like the Chef or the metabuilder (which are much more convenient and will have to be supported by the next release).
Fixes #331