Skip to content

Conversation

@ilario
Copy link
Member

@ilario ilario commented Jan 4, 2020

As reported by @dangowrt in #331, the conditional dependencies work only when compiling using the buildroot method (which is currently the recommended one, see https://libremesh.org/development.html) but not with methods employing the imagebuilder, like the Chef or the metabuilder (which are much more convenient and will have to be supported by the next release).

Fixes #331

@G10h4ck
Copy link
Member

G10h4ck commented Jan 6, 2020

I do not agree with this changes, chef and image builder should eventually solve their limitation instead.

Also something like chef could be programmed on top of the buildroot instead, which have lot mroe advantages and much less bugs that imagebuilder and similar...

@ilario
Copy link
Member Author

ilario commented Jan 7, 2020

Also something like chef could be programmed on top of the buildroot instead

History is cyclic, they say. In august I commented #558 (comment)

compilation method has changed over the time (buildroot, lime-build, lime-sdk, buildroot)

and your comment means that we'll have the lime-build again!!!!!

@ilario
Copy link
Member Author

ilario commented Jan 20, 2020

and your comment means that we'll have the lime-build again!!!!!

Maybe GuifiPedro's TEMBA with this example could be used as the new lime-build? @G10h4ck

@ilario
Copy link
Member Author

ilario commented Jun 8, 2020

In this PR I removed also batctl from lime-debug:
in OpenWrt 18.06 could be annoying but if we add a hard dependency on batctl, also kmod-batman-adv will be selected by lime-debug (as kmod-batman-adv is a dependency of batctl in 18.06)
the opposite happens in OpenWrt 19.07, so there's no need for lime-debug to depend on batctl as it is a dependency of kmod-batman-adv.

@ilario ilario force-pushed the condicional_dep branch from f8d4808 to 92b2743 Compare June 8, 2020 09:55
@ilario
Copy link
Member Author

ilario commented Jun 8, 2020

I removed the commit about lime-proto-bmx6 which is better addressed in #716.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   73.90%   73.90%           
=======================================
  Files          34       34           
  Lines        2817     2817           
=======================================
  Hits         2082     2082           
  Misses        735      735           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7181c3b...f7760fb. Read the comment docs.

@ilario
Copy link
Member Author

ilario commented Sep 23, 2020

The following conditional dependencies are addressed in this PR.

  • lime-proto-wan: +!PACKAGE_firewall:iptables
  • lime-proto-bmx6: +!PACKAGE_firewall:iptables
  • lime-webui: +PACKAGE_lime-proto-bmx6:luci-app-bmx6
  • lime-webui: +PACKAGE_lime-proto-batadv:luci-app-batman-adv
  • lime-debug: +PACKAGE_lime-proto-batadv:batctl
  • shared-state-dnsmasq_leases: @(!PACKAGE_dnsmasq-lease-share) (what is this syntax??) this package does not even exist anymore!!!
  • lime-map-agent: +PACKAGE_lime-proto-bmx6:luci-lib-libremap-bmx6

@codecov-io
Copy link

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   73.62%   73.62%           
=======================================
  Files          35       35           
  Lines        2972     2972           
=======================================
  Hits         2188     2188           
  Misses        784      784           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72195...58dc639. Read the comment docs.

@ilario ilario merged commit a45d93a into libremesh:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cascade of metapackages kills modularity

6 participants