lime-proto-bgp depend on bird1-* packages from OpenWrt 19.07 #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiccinini
approved these changes
Sep 23, 2020
ilario
requested review from
altergui,
aparcar,
dangowrt,
germanferrero,
gmarcos87 and
luandro
G10h4ck
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #645
This will remove the Warning (it is not an Error!!!) from the compilation with OpenWrt 19.07 but will add the warning to the compilation with OpenWrt 18.06. I have no idea how to write a dependency valid both for OpenWrt 18.06 and 19.07 without using conditional dependencies which are evil (see #331 #673 ).
Here you can find the Bird Makefile in 18.06 and the Bird1 Makefile in 19.07.
Plenty of users were alarmed by this warning (DrivenMadz on IRC/Element, #750, #645, on the ML here, here, here).