fix: make the behaviour of methods which set hid_error more consistent#425
Closed
Julusian wants to merge 1 commit intolibusb:masterfrom
Closed
fix: make the behaviour of methods which set hid_error more consistent#425Julusian wants to merge 1 commit intolibusb:masterfrom
Julusian wants to merge 1 commit intolibusb:masterfrom
Conversation
Contributor
Author
|
I suppose that it could be fine as it, as you know that there is a new error from the return code, so maybe none of this is necessary other than the docs fix |
Member
|
You are right, there is so much wrong about We've introduced a lot problems by trying to make an improvement.
Let me finally start making it right. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From reading through the code I found that the behaviour of
hid_error()was rather inconsistent at times.The windows implementation would only set the device error if it encountered an error, and would never clear the last error.
The linux hidraw implementation would sometimes clear it, but not always.