Conversation
Youw
added
enhancement
Member
Author
|
@Julusian if you have comments regarding this - feel free to leave them here. |
Contributor
|
Yeah this looks fine to me. Initially it felt like a shame to lose the thread safety of the error on linux, but as long as hid_open, hid_enumerate, hid_init are contained to a single thread (which it looks like they should be anyway), then I dont see it losing any safety. |
Member
Author
Yeap, still need to write the documentation for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the documentation and the implementation of
hid_errorconsistent and safe.The discussion and reasoning on thread safety is here.
Closes: #425