This repository was archived by the owner on May 25, 2023. It is now read-only.
Switch from akka.discovery.method#184
Merged
eed3si9n merged 2 commits intolightbend:masterfrom Jan 8, 2019
Merged
Conversation
to akka.management.cluster.bootstrap.contact-point-discovery.discovery-method. Fixes lightbend#173 Ref akka/akka-management#316 This was tested using the integration testing on reactive-lib lightbend/reactive-lib#106
ghost
assigned
ignasi35
approved these changes
Jan 8, 2019
ignasi35
reviewed
Jan 8, 2019
ignasi35
left a comment
ignasi35
left a comment
There was a problem hiding this comment.
Can we add a test for kubernetes?
Something in https://github.com/lightbend/reactive-cli/blob/master/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala#L342 ?
Contributor
Author
|
I have a test in the next PR - #185 |
Contributor
Author
|
Brought the test here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to akka.management.cluster.bootstrap.contact-point-discovery.discovery-method.
For Akka Cluster Bootstrap we can use more specific setting
contact-point-discovery.discovery-methodinstead of taking over the entireakka.discovery.method. This frees upakka.discovery.methodto be used for generic service discovery setting for example to chain config and DNS.Fixes #173
Ref akka/akka-management#316
This was tested using the integration testing on reactive-lib lightbend/reactive-lib#106
/cc @lightbend/play-lagom