This repository was archived by the owner on May 25, 2023. It is now read-only.
Specify contact-point-discovery.port-name#185
Merged
eed3si9n merged 2 commits intolightbend:masterfrom Jan 8, 2019
Merged
Conversation
ghost
assigned
octonato
reviewed
Jan 8, 2019
cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala
Outdated
Show resolved
Hide resolved
Fixes lightbend#177 This specifies the management endpoint name explicity to `-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name`. By default the management endpoint name will fallback to `"akka-mgmt-http"` for backward compatibility. In the future, sbt-reactive-app can declare the management endpoint name using "management-endpoint" as a label on the Docker image. See lightbend/sbt-reactive-app#164. These changes combined together provides softlanding of the switch to `"management"` in akka/akka-management#274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #184
Fixes #177
This specifies the management endpoint name explicity to
-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name.By default the management endpoint name will fallback to
"akka-mgmt-http"for backward compatibility.In the future, sbt-reactive-app can declare the management endpoint name using "management-endpoint" as a label on the Docker image. See lightbend/sbt-reactive-app#164.
These changes combined together provides softlanding of the switch to
"management"in akka/akka-management#274./cc @lightbend/play-lagom