I can has extension?#623
Closed
ZmnSCPxj wants to merge 1 commit into
Closed
Conversation
ZmnSCPxj
force-pushed
the
icanhasextension
branch
from
cbc39e1 to
6d4b70b
Compare
renepickhardt
suggested changes
Jul 1, 2019
Contributor
renepickhardt
left a comment
renepickhardt
left a comment
There was a problem hiding this comment.
I think this idea is pretty useful. I passed my feedback inline. I think we should really change the name of the messages. My other feedback seems like it is all already in there but I thought I would still drop it as it might improve the overall readability of this BOLT because these where the points while reading with which I seemed to have some issues.
ZmnSCPxj
force-pushed
the
icanhasextension
branch
from
6d4b70b to
5337c7b
Compare
This was referenced Aug 19, 2019
Contributor
|
What is the current status of these proposal? It would be great to have it accepted |
Collaborator
Author
|
I do not know proper procedure for how to get these merged, though am interested in somehow getting it in. |
Collaborator
Author
|
Subsumed by #705 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for permissionless development of experimental features.
I believe this can be added to the spec almost entirely as-is, although it does remove 25% of the possible space of available messages for itself.