BOLT 1: Define custom message type range#705
Merged
Merged
Conversation
pm47
previously requested changes
Nov 21, 2019
| - MUST include all the fields annotated with that option. | ||
| - When defining custom messages: | ||
| - SHOULD pick a random `type` to avoid collision with other custom types. | ||
| - SHOULD pick an odd `type` identifiers when regular nodes should ignore the |
Collaborator
There was a problem hiding this comment.
The it's ok to be odd rule isn't type-specific so there is no need to repeat it here.
Collaborator
Author
There was a problem hiding this comment.
We chose to repeat it when we spec-ed the onion TLV namespace for experimentation; I did the same here for consistency but can remove it.
Collaborator
|
Excellent proposal, this fits in perfectly with c-lightning's ACK dc60034 |
Collaborator
Author
|
Great, looks like we're all going in the same direction so let's make this official ;) |
Closed
cdecker
force-pushed
the
b01-custom-message-range
branch
from
b606404 to
10e9a88
Compare
Collaborator
|
Rebased and squashed fixups. Merging following the spec meeting on 2020/01/20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines a message type range for custom messages. The goal is to prevent unofficial messages from allocating types in the official range.
Experimentation and application-specific messages should have a way to choose "safe" message types that won't collude with a future spec-ed (official) message.