Move check_commits CI to dedicated workflow (main)#3966
Move check_commits CI to dedicated workflow (main)#3966TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
check_commits CI to dedicated workflow (main)#3966Conversation
|
🎉 This PR is now ready for review! |
tnull
changed the title
check_commits CIcheck_commits CI (main)
Previously, we introduced a chance dynamically determining the base branch for the check_commits CI job. Unfortunately it used the base_ref variable, which is only set for pull_requests, not for pushes. Here, we hence move `check_commits` to a dedicated workflow that only is run on PRs.
tnull
force-pushed
the
2025-07-fix-the-fix
branch
from
bc43204 to
9893797
Compare
tnull
changed the title
check_commits CI (main)check_commits CI to dedicated workflow (main)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01%
==========================================
Files 174 174
Lines 123869 123876 +7
Branches 123869 123876 +7
==========================================
- Hits 110161 110158 -3
- Misses 11256 11258 +2
- Partials 2452 2460 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
Previously, we introduced a chance dynamically determining the base
branch for the
check_commitsCI job. Unfortunately it used the base_refvariable, which is only set for pull_requests, not for pushes. Here, we
hence move
check_commitsto a dedicated workflow that only is run onPRs.