Drop incremental-mutants CI job (main)#3953
Drop incremental-mutants CI job (main)#3953TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
incremental-mutants CI job (main)#3953Conversation
Previously, the `incremental-mutants` CI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job. Here we therefore drop `incremental-mutants` from our CI for the time being.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
tnull
changed the title
incremental-mutants CI jobincremental-mutants CI job (main)
|
Will undraft once we reach a conclusive decision on #3948. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
==========================================
- Coverage 88.95% 88.94% -0.02%
==========================================
Files 168 174 +6
Lines 121974 123876 +1902
Branches 121974 123876 +1902
==========================================
+ Hits 108502 110181 +1679
- Misses 11072 11245 +173
- Partials 2400 2450 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Discussed this at the dev sync, everybody seemed to be in favor or at least not against dropping it. So undrafting. |
|
Ugh, seems this has us now always failing Will put up a fix. |
|
Should be fixed in #3966 |
3 participants
Closes #3948.
Previously, the
incremental-mutantsCI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job.Here we therefore drop
incremental-mutantsfrom our CI for the time being.