Drop now-removed doc_auto_cfg feature#4158
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
Backported to 0.2 in #4159 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4158 +/- ##
==========================================
- Coverage 88.79% 88.76% -0.04%
==========================================
Files 180 180
Lines 136553 136553
Branches 136553 136553
==========================================
- Hits 121259 121216 -43
- Misses 12494 12532 +38
- Partials 2800 2805 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
These have been merged, causing our docs.rs builds to fail. Sadly, we saw our docs.rs build fail for the 0.1.6 upload because of this.
TheBlueMatt
force-pushed
the
2025-10-docsrs
branch
from
68e4314 to
a942df2
Compare
|
Yea, you're right we probably should keep the flag. I tried to push a CI job to emulate docs.rs builds so that we actually test this before we upload releases. |
TheBlueMatt
force-pushed
the
2025-10-docsrs
branch
7 times, most recently
from
ed229ca to
8f3058d
Compare
| run: | | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }} | ||
| - name: Simulate docs.rs build | ||
| run: ci/check-docsrs.sh |
There was a problem hiding this comment.
Ran ./ci/check-docsrs.sh on my machine without the prior commit, and it does not complain.
There was a problem hiding this comment.
I assume that is because stable rust hasn't removed the feature flag yet. Not really sure how to properly capture that cause nightly currently fails to build docs just because of nightly breakages...
Sadly, our docs.rs build failed for 0.1.6 due to the unstable `doc_auto_cfg` feature being removed. Here, we try to emulate docs.rs builds as best we can in CI to head that off in the future.
TheBlueMatt
force-pushed
the
2025-10-docsrs
branch
from
8f3058d to
d3faa03
Compare
|
Replaced the CI job with |
[0.2] Backport #4158 and bump versions to -beta1
|
Backported in #4166. |
3 participants
It seems new rustc removed this feature, hopefully its available upstream but either way it caused the 0.1.6 docs.rs build to fail.