Merged
Conversation
These have been merged, causing our docs.rs builds to fail. Sadly, we saw our docs.rs build fail for the 0.1.6 upload because of this. Backport of 6aea586 Resolved conflicts in: * lightning-background-processor/src/lib.rs * lightning-liquidity/src/lib.rs * lightning/src/lib.rs
Sadly, our docs.rs build failed for 0.1.6 due to the unstable `doc_auto_cfg` feature being removed. Here, we try to emulate docs.rs builds as best we can in CI to head that off in the future. Backport of d3faa03
In our upgrade/downgrade tests we want to be able to use the functional test utils as-is externally as a part of CI in later LDK versions. This implies that code that is `cfg(test)` really needs to always be `cfg(any(test, feature = "_test_utils"))`. Sadly, trying to open multiple channels back-to-back on a node with `_test_utils` currently fails as we re-broadcast channel announcement messages, something the functional test utils does not expect. Here we update the `cfg`-flagging of that rebroadcast logic to fix back-to-back channel opens in `_test_utils`. This narrowly backports one hunk of the much larger upstream commit e41e756.
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
Backport of 1ca41b5
TheBlueMatt
force-pushed
the
2025-10-0.1.7
branch
from
3d1b704 to
72045a1
Compare
TheBlueMatt
force-pushed
the
2025-10-0.1.7
branch
from
72045a1 to
6c5399b
Compare
Backports the documentation changes from 2ce8e64
TheBlueMatt
force-pushed
the
2025-10-0.1.7
branch
from
6c5399b to
ac33016
Compare
tankyleo
approved these changes
Oct 21, 2025
Contributor
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
./ci/ci-tests.sh passed on my machine
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
valentinewallace
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the docs.rs build but also fixes _test_utils channel opens which I need for a splicing upgrade test I want to land for 0.2.