Add Upfront Shutdown Address to OpenChannelRequest#3796
Conversation
389ac03 to
c15529f
Compare
|
While working on a first iteration of this PR which had feature bits in |
730d686 to
dd2c6eb
Compare
|
Rebased on #3824 to use common method, so first two commits are not up for review. |
dd2c6eb to
669eb19
Compare
cfromknecht
left a comment
There was a problem hiding this comment.
@carlaKC clean pr! first two commits are in master now so we can rebase.
excited that we'll now have some moree insight into our peer's features. i wonder if maybe we should add the remote init features to listpeers as well? other than that, only a few small comments left.
|
also note that #3837 proposes changing the rpc features to a map |
a7ca7d8 to
cc423fa
Compare
cc423fa to
2c84620
Compare
wpaulino
left a comment
There was a problem hiding this comment.
Confirmed in a test environment I was only able to coop close out to the upfront address.
2c84620 to
2482ee4
Compare
|
Rebased to address merge conflict 👮♀ |
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM! 🥂 one small nit
|
@carlaKC needs rebase |
2482ee4 to
eb3a2e6
Compare
This PR adds an upfront shutdown address to lnrpc and lncli. Cooperative close out to these addresses is enforced provided that the remote peer supports the feature bit. The request will fail if an address is set for a peer that does not support upfront shutdown.
It also exposes the features that peers support in a new rpc endpoint
GetFeaturesso that users can check whether the peer supports the feature before setting the field (and check which features their node supports, if desired), which has the following output:Fixes #3786