lnrpc: expose features on rpc invoices#3824
Merged
cfromknecht merged 2 commits intoDec 12, 2019
Merged
Conversation
cfromknecht
force-pushed
the
invoice-features-rpc
branch
from
fbf9838 to
1812dd1
Compare
cfromknecht
added
payments
joostjager
reviewed
Dec 12, 2019
carlaKC
approved these changes
Dec 12, 2019
Collaborator
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
+1 for an IsKnown function on features but LGTM otherwise 🌮
In the process, we also move the feature serialization into the invoicesrpc package, so that it can be shared between the invoicesrpc and main rpcserver.
cfromknecht
force-pushed
the
invoice-features-rpc
branch
from
1812dd1 to
aba49c9
Compare
joostjager
approved these changes
Dec 12, 2019
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
Did a quick listinvoices test. It works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3802 we exposed the features on a payreq decoded using the
decodepayreqrpc. In this PR, we take this one step further by displaying it on alllnrpc.Invoiceobjects. This allows the invoice generator to see what features are being advertised on their invoices.