Skip to content

lnrpc: expose features on rpc invoices #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfromknecht merged 2 commits into from
Dec 12, 2019
Merged

lnrpc: expose features on rpc invoices #3824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7446495
lnrpc: add features field to invoices
cfromknecht Dec 12, 2019
aba49c9
rpcserver: populate features on lnrpc invoices
cfromknecht Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lnrpc/invoicesrpc/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"github.com/btcsuite/btcd/chaincfg"
"github.com/lightningnetwork/lnd/channeldb"
"github.com/lightningnetwork/lnd/lnrpc"
"github.com/lightningnetwork/lnd/lnwire"
"github.com/lightningnetwork/lnd/zpay32"
)

Expand Down Expand Up @@ -116,6 +117,7 @@ func CreateRPCInvoice(invoice *channeldb.Invoice,
AmtPaid: int64(invoice.AmtPaid),
State: state,
Htlcs: rpcHtlcs,
Features: CreateRPCFeatures(invoice.Terms.Features),
}

if preimage != channeldb.UnknownPreimage {
Expand All @@ -125,6 +127,22 @@ func CreateRPCInvoice(invoice *channeldb.Invoice,
return rpcInvoice, nil
}

// CreateRPCFeatures maps a feature vector into a list of lnrpc.Features.
func CreateRPCFeatures(fv *lnwire.FeatureVector) []*lnrpc.Feature {
features := fv.Features()
rpcFeatures := make([]*lnrpc.Feature, 0, len(features))
for bit := range features {
rpcFeatures = append(rpcFeatures, &lnrpc.Feature{
Bit: uint32(bit),
Name: fv.Name(bit),
IsRequired: bit.IsRequired(),
IsKnown: fv.IsKnown(bit),
})
}

return rpcFeatures
}

// CreateRPCRouteHints takes in the decoded form of an invoice's route hints
// and converts them into the lnrpc type.
func CreateRPCRouteHints(routeHints [][]zpay32.HopHint) []*lnrpc.RouteHint {
Expand Down
Loading