Sample pull request. Allows specification of BTCD parameters.#7
Conversation
mkl-
commented
Feb 1, 2016
- Allows specification BTCD parameters. If not specified read them from btcd.conf file
- Allows specification network parameters
|
Thanks for the PR @mkl-! I've been meaning to set up proper config parsing, and a separate config file for However, importing the entire config struct from Additionally, although The added print statements are unnecessary as Finally, although we currently have the active Bitcoin network set to |
|
But hey, how about we salvage this PR into something merge-able? Here's how I recommend you proceed, if you'd still like to contribute 😎.
You can either re-brand this PR with the above changes, or close this PR, instead creating a new PR implementing the above. It's up to you 🏂. |
|
I've rewritten configuration using approach similar to btcd: command line options + configuration file. Could you please explain what is testnetL and how to use it? |
|
Great! I'll close this PR so we can move along with #8. So it turns out we've decided to abandon testnetL. Instead, we're now using segnet for testing purposes since it has the malleability fixes we need for LN, and this way we don't have to maintain our own testnet ;) |
Initiate as a custom repository
Check that the node ann doesnt contain more than 1 DNS addr. This will ensure that we now start rejecting new node announcements with multiple DNS addrs since this check is called in the gossiper before persisting a node ann to our local graph. It also validates the DNS fields according to BOLT #7 specs.
Check that the node ann doesnt contain more than 1 DNS addr. This will ensure that we now start rejecting new node announcements with multiple DNS addrs since this check is called in the gossiper before persisting a node ann to our local graph. It also validates the DNS fields according to BOLT #7 specs.