Config#8
Conversation
| ) | ||
|
|
||
| const ( | ||
| defaultConfigFilename = "lnwallet.conf" |
There was a problem hiding this comment.
The name of the config file should instead be: "lnd.conf". lnwallet has it's own config struct, be we'll only require users to fill out a single concrete configuration file.
|
Hey @mkl-, thanks for working with me in order to get morph your previous PR into something merge-able! This looks pretty good to me, but I have a few comments I'd like addressed before I merge this in. I've completed a preliminary review, but I have yet to test this branch against the current state of master yet. |
| defaultBTCDHost = "localhost:18334" | ||
| defaultBTCDUser = "user" | ||
| defaultBTCDPass = "passwd" | ||
| defaultBTCDCACertPath = "" |
There was a problem hiding this comment.
This can be safely set with something along the lines of:
btcdHomeDir = btcutil.AppDir("btcd", false)
defaultBTCDCACertPath = filepath.Join(btcdHomeDir, "rpc.cert")
|
Hey @mkl-, thanks for starting the work to add a config to Stepping off your shoulders, I've also finalized the logging, configuration, and signal handling functionality within Closing this now, thanks again! |
…om-commits Add "legacy" custom commit
2 participants
Allow to config lnd using command line options as well as using configuration file.
Approach is very similar to approach used in btcd.
It seems that lnd still uses btcd in some form so I left configuration options for it.