Skip to content

wallet: improve logging around transaction broadcast failures#7513

Merged
guggero merged 1 commit intolightningnetwork:masterfrom
guggero:publish-tx-logging
Apr 11, 2023
Merged

wallet: improve logging around transaction broadcast failures#7513
guggero merged 1 commit intolightningnetwork:masterfrom
guggero:publish-tx-logging

Conversation

@guggero
Copy link
Copy Markdown
Collaborator

@guggero guggero commented Mar 14, 2023

Related to #7505.

Depends on btcsuite/btcwallet#851.

The logging around transaction broadcast failures has been improved by always logging the causing error and the raw transaction as hex.

@guggero guggero requested review from Roasbeef and yyforyongyu March 14, 2023 19:56
@guggero guggero force-pushed the publish-tx-logging branch from 678b871 to 9ee7e44 Compare March 16, 2023 11:31
@guggero
Copy link
Copy Markdown
Collaborator Author

guggero commented Mar 16, 2023

Rebased and updated after depending PR was merged.

Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🤙

@lightninglabs-deploy
Copy link
Copy Markdown
Collaborator

@Roasbeef: review reminder

Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦜

@Roasbeef Roasbeef added this to the v0.16.1 milestone Apr 6, 2023
@Roasbeef Roasbeef changed the base branch from 0-16-1-staging to master April 6, 2023 00:34
@Roasbeef
Copy link
Copy Markdown
Member

Needs a rebase then this can land.

@guggero
Copy link
Copy Markdown
Collaborator Author

guggero commented Apr 11, 2023

The btcwallet dependency was already bumped in #7529. So this only contains the change log entry.

@guggero guggero merged commit 559cb47 into lightningnetwork:master Apr 11, 2023
@guggero guggero deleted the publish-tx-logging branch April 12, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants