Check for nonWitness UTXO or witness UTXO data in the psbt inputs

[ziggie1984]

This relates to #7527, btcsuite/btcwallet#852, btcsuite/btcd#1964

I guess we also want to use the new InputsReadyToSign when using the remote signer setup and the SignPsbt function.

If so, then I still need to add some tests for FinalizePsbt and SignPsbt. I would introduce those tests at the rpc level ? Maybe in a new walletkit_server_test.go?

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

• Your PR passes all CI checks.
• Tests covering the positive and negative (error paths) are included.
• Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

• The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
• Commits follow the Ideal Git Commit Structure.
• Any new logging statements use an appropriate subsystem and logging level.
• There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

[positiveblue]

Blocking changes in github.com/btcsuite/btcd and github.com/btcsuite/btcwallet merged 🎉

I guess we can move this out of drafts?

[ziggie1984]

I think, I need a new tag for the btcwallet instance to bump the version accordingly ?

As a preliminary step, I replaced the btcwallet import with my import to not fail at the lint, this must be replaced by a new btcwallet tag IMO, so it just to pass all the checks and see whether the PR is ready to go.

Still one question: this PR does not add any tests and I am unsure whether we wanna add some tests at the rpc level (not quite sure how to do it but I would try to implement it). But otherwise this change is so small, maybe not worth it to add tests? Happy to hear your perspective

[guggero]

The way you updated the btcwallet dependency is fine for now. Because there might be more changes/updates necessary for 0.16.1 we usually only tag the main repository modules when we create a new lnd release (this is a bit different from submodules like btcutil/psbt which might be used by other projects independently).

Regarding tests, we could very easily add a test here: https://github.com/lightningnetwork/lnd/blob/master/itest/lnd_psbt_test.go#L1023
For example create a copy of the packet, remove the witness and non-witness UTXOs on one input and assert the correct error is returned.

[ziggie1984]

I added a simple testcase stripping all the input UTXO data and trying to sign the psbt.

[guggero]

Test case looks good to me, thanks for adding that!
Just a comment around naming and error passing, other than that this seems to be ready.

[guggero]

LGTM, thanks 🎉

[guggero]

Needs a rebase.

[positiveblue]

Thank you @ziggie1984 🌮

Everything looks good, we only need to rebase and it is ready to be merged 🚀