lnwire: add lnwire.OpaqueAddr case in WriteElement for channel back-ups#9856
Merged
guggero merged 4 commits intolightningnetwork:masterfrom May 26, 2025
Merged
lnwire: add lnwire.OpaqueAddr case in WriteElement for channel back-ups#9856guggero merged 4 commits intolightningnetwork:masterfrom
guggero merged 4 commits intolightningnetwork:masterfrom
Conversation
Use existing serialisation helpers for serialising TC Pand Onion addresses in WriteElement.
And then expand the chanbackup unit tests to cover such a case.
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ellemouton
force-pushed
the
writeOpaqueAddr
branch
from
7886390 to
b67cd82
Compare
ellemouton
changed the title
8 tasks
ziggie1984
approved these changes
May 24, 2025
| @@ -0,0 +1,88 @@ | |||
| # Release Notes | |||
Collaborator
There was a problem hiding this comment.
Nit: release notes also contain other PRs as new.
Collaborator
Author
There was a problem hiding this comment.
indeed - removed!
ellemouton
force-pushed
the
writeOpaqueAddr
branch
from
b67cd82 to
9d54dbc
Compare
guggero
approved these changes
May 26, 2025
pinheadmz
added a commit
to Jhoyola/warnet
that referenced
this pull request
Feb 27, 2026
pinheadmz
added a commit
to Jhoyola/warnet
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a serialisation bug that would occur when an attempt was made to write
a backup file for a channel peer that has advertised an address that we do
not yet know how to parse.
The
WriteElementmethod did not have a type for the newlnwire.OpaqueAddrtype.WriteElementis only used for addresses from withinchanbackupand so if a node has a channel peer that is advertising an address that we dont know how to parse yet, we would let it be anlnwire.OpaqueAddrtype and this would then error out when we try to make a static chan backup for that peer.