release: create branch for v0.19.1-beta.rc1#9896
Merged
guggero merged 35 commits into0-19-1-branchfrom Jun 4, 2025
Merged
Conversation
Use existing serialisation helpers for serialising TC Pand Onion addresses in WriteElement.
And then expand the chanbackup unit tests to cover such a case.
Move bumpfee RPC related tests into one file - these tests focus on testing the behaivor of the RPC only without any force close context.
This commit introduces a new `IsRunning()` method to the `StateMachine`. This method allows callers to safely query whether the state machine is currently active after it has been started and before it has been stopped. To ensure thread-safety, the internal `running` status flag is implemented using `atomic.Bool` (from `sync/atomic`). Without atomic operations, concurrent accesses to a simple boolean flag from different goroutines (e.g., one goroutine calling `IsRunning()` while another executes `Start()` or `Stop()`) could lead to stale reads or data races.
Update unit test to call `StateMachine.IsRunning()` to ensure the method has test coverage.
Add a connect/disconnect test when the peers both started up with the rbf coop close feature.
In case when the rbf coop close feature was active we would not properly disconnect the peer.
In this commit, we start to signal the prod bit for the rbf coop close feature. We keep our signaling of the staging bit in place to ensure the protocol continues to work between those nodes in the wild that are still signaling the bit. Fixes #9852
We add logging to we can draw conclusions how long the processing of gossip message last and potentially see whether the syncer buffer channel size is a bottleneck in processing.
If a peer has, or used to have a channel with us there's no need to check for the ban score.
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull reviewers statsStats of the last 30 days for lnd:
|
Collaborator
|
Is the memory fix missing ? |
ziggie1984
approved these changes
Jun 4, 2025
Collaborator
ziggie1984
left a comment
ziggie1984
left a comment
There was a problem hiding this comment.
LGTM (memfix is already in 19.1 branch)
Member
That's included in the base branch |
yyforyongyu
reviewed
Jun 4, 2025
guggero
force-pushed
the
0-19-1-rc1-branch
branch
from
33efc68 to
fedc4c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases the following PRs from the 0.19.1 milestone onto the
0-19-1-branch:btcwalletto fixFetchOutpointInfo#9854StateMachine.IsRunning()in unit test #9885