peer+feature: start to signal the prod rbf coop close bit#9858
Merged
guggero merged 1 commit intolightningnetwork:masterfrom Jun 3, 2025
Merged
peer+feature: start to signal the prod rbf coop close bit#9858guggero merged 1 commit intolightningnetwork:masterfrom
guggero merged 1 commit intolightningnetwork:masterfrom
Conversation
In this commit, we start to signal the prod bit for the rbf coop close feature. We keep our signaling of the staging bit in place to ensure the protocol continues to work between those nodes in the wild that are still signaling the bit. Fixes lightningnetwork#9852
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
|
@ziggie1984: review reminder |
ziggie1984
approved these changes
Jun 3, 2025
| SetInit: {}, // I | ||
| SetNodeAnn: {}, // N | ||
| }, | ||
| lnwire.RbfCoopCloseOptional: { |
Collaborator
There was a problem hiding this comment.
We should eventually tho remove RbfCoopCloseOptionalStaging in LND 20 or later so that we don't keep this around.
Collaborator
There was a problem hiding this comment.
Created an issue for this.
guggero
added a commit
that referenced
this pull request
Jun 4, 2025
guggero
added a commit
that referenced
this pull request
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we start to signal the prod bit for the rbf coop close feature. We keep our signaling of the staging bit in place to ensure the protocol continues to work between those nodes in the wild that are still signaling the bit.
Fixes #9852