protofsm: add thread-safe IsRunning method to StateMachine#9883
Merged
guggero merged 1 commit intolightningnetwork:masterfrom Jun 2, 2025
Merged
protofsm: add thread-safe IsRunning method to StateMachine#9883guggero merged 1 commit intolightningnetwork:masterfrom
guggero merged 1 commit intolightningnetwork:masterfrom
Conversation
This commit introduces a new `IsRunning()` method to the `StateMachine`. This method allows callers to safely query whether the state machine is currently active after it has been started and before it has been stopped. To ensure thread-safety, the internal `running` status flag is implemented using `atomic.Bool` (from `sync/atomic`). Without atomic operations, concurrent accesses to a simple boolean flag from different goroutines (e.g., one goroutine calling `IsRunning()` while another executes `Start()` or `Stop()`) could lead to stale reads or data races.
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
guggero
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
IsRunning()method to theStateMachine. This method allows callers to safely query whether the state machine is currently active after it has been started and before it has been stopped.To ensure thread-safety, the internal
runningstatus flag is implemented usingatomic.Bool(fromsync/atomic). Without atomic operations, concurrent accesses to a simple boolean flag from different goroutines (e.g., one goroutine callingIsRunning()while another executesStart()orStop()) could lead to stale reads or data races.