Conversation
… outputs JSON instead of bytes.
|
Hey, I saw Also, it's important to know:
ALSO: When creating a PR it's always useful to write a summary of the changes, e.g. this is a copy of the original HTTP/proto exporter with changes in line X and XX to mutate data to JSON, etc. |
…ort actual JSON transformation.
Updated. Sorry. That was a result of my back and forth experiments on structuring the component. Initially, I thought creating a completely new one under http-json directory but decided to go light for POC. |
Cannot answer right now. You are right that JS exporter uses explicit JS methods. Whereas Java uses writeJsonTo method. The output definitely can be different as these are two completely different project and different languages. |
No. I am trying to set up testing environment locally using collector. If you know any easy and quick way to test it without creating a package - let me know. |
Removed all unused commented code.
…p/opentelemetry-java into feature/opentelemetry-java/3651
…p/opentelemetry-java into feature/opentelemetry-java/3651
…p/opentelemetry-java into feature/opentelemetry-java/3651
open-telemetry#3770) * Replaced hardcoded localhost with OS resolved localhost name in tests. * Replaced hardcoded localhost with OS resolved localhost name in tests. open-telemetry#2 * retrigger checks #1
This is copy of the original HTTP/protobuf exporter modified to convert message body to protobuf/JSON instead of protobuf/binary.