Replaced hardcoded test host name with the one properly resolved by OS#3770
Merged
jkwatson merged 4 commits intoopen-telemetry:mainfrom Oct 20, 2021
Merged
Replaced hardcoded test host name with the one properly resolved by OS#3770jkwatson merged 4 commits intoopen-telemetry:mainfrom
jkwatson merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3770 +/- ##
============================================
+ Coverage 89.08% 89.17% +0.08%
- Complexity 3917 3961 +44
============================================
Files 470 471 +1
Lines 12344 12478 +134
Branches 1208 1231 +23
============================================
+ Hits 10997 11127 +130
+ Misses 945 939 -6
- Partials 402 412 +10
Continue to review full report at Codecov.
|
Contributor
Author
|
/easycla |
Member
|
nice, i'll have to see if this can help with situation in instrumentation repo, currently we have some loose assertions to account for similar issue |
Contributor
Author
|
Sorry, everybody. |
Contributor
Author
|
Never mind. It seems that my personal CLA request got approved. Reopening this again with all passed tests! |
This was referenced Dec 19, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes:
#3619