Skip to content

ci: Cleanup iperf3 tests #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 2 commits into from
Nov 23, 2024
Merged

ci: Cleanup iperf3 tests #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fed4a3
ci: Cleanup iperf3 tests
nirs Nov 22, 2024
f469a40
ci: Simplify limactl start command
nirs Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,24 +82,24 @@ jobs:
run: brew install iperf3 jq
- name: "Lima: vm1: prepare"
run: |
limactl start --name=vm1 --set '.cpus=1 | .memory = "1GiB"' --tty=false ./test/vmnet.yaml
limactl start --name=vm1 --tty=false ./test/vmnet.yaml
limactl shell vm1 ip a
- name: "Lima: vm1: set up iperf3"
run: |
limactl shell vm1 sudo DEBIAN_FRONTEND=noninteractive apt-get install -y iperf3
limactl shell vm1 systemd-run --user --unit=iperf3 iperf3 -s
limactl shell vm1 sudo systemctl start iperf3.service
- name: "Lima: vm1: get the IP"
run: |
limactl shell vm1 ip -4 -json addr show dev lima0 | jq -r .[0].addr_info[0].local | tee /tmp/vm1_iP
- name: "Lima: vm1: iperf3 (host -> vm1)"
run: |
iperf3 -c "$(cat /tmp/vm1_ip)"
iperf3-darwin -c "$(cat /tmp/vm1_ip)"
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this solve the macos-15 issue? 👀

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this solves the issue - just another cleanup to unify the way we run host to vm tests, used in test/perf.sh.

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I can split the changes to check which change is the fix.

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed iperf3-darwin here:
283be46

macos-15-large run:
https://github.com/lima-vm/socket_vmnet/actions/runs/11980909877/job/33406141644

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't use this is test/perf.sh - this the way I'm testing manually with vfkit, I need to update test/perf.sh.

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job failed without iper3-darwin:
https://github.com/lima-vm/socket_vmnet/actions/runs/11980909877/job/33406141644

Maybe it uses different DNS resolver?

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the test doesn't seem relying on DNS?

Copy link
Copy Markdown
Member Author

@nirs nirs Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this must be something else.

- name: "Lima: vm1: debug"
if: failure()
run: tail -n500 ~/.lima/vm1/*.log
- name: "Lima: vm2: prepare"
run: |
limactl start --name=vm2 --set '.cpus=1 | .memory = "1GiB"' --tty=false ./test/vmnet.yaml
limactl start --name=vm2 --tty=false ./test/vmnet.yaml
limactl shell vm2 ip a
- name: "Lima: vm2: set up iperf3"
run: |
Expand Down
2 changes: 2 additions & 0 deletions test/vmnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,7 @@ mounts:
- location: "~"
- location: "/tmp/lima"
writable: true
memory: "1g"
cpus: 1
networks:
- lima: shared