Skip to content

ci: Cleanup iperf3 tests#83

Merged
AkihiroSuda merged 2 commits into
lima-vm:masterfrom
nirs:ci-cleanups
Nov 23, 2024
Merged

ci: Cleanup iperf3 tests#83
AkihiroSuda merged 2 commits into
lima-vm:masterfrom
nirs:ci-cleanups

Conversation

@nirs
Copy link
Copy Markdown
Member

@nirs nirs commented Nov 22, 2024

  • Start iperf3 service instead of using systemd run since this is the standard way to start the server.
  • Use iperf3-darwin since it provides additional info (RTT) - without this the job fails.
  • Simplify limactl start command

With these changes the macos-15-large test is successful: https://github.com/lima-vm/socket_vmnet/actions/runs/11980467424/job/33404783754

- Start iperf3 service instead of using systemd run since this is the
  standard way to start the server.
- Use iperf3-darwin since it provides additional info (RTT).

With this changes the macos-15 test is successful:
https://github.com/lima-vm/socket_vmnet/actions/runs/11980467424/job/33404783754

Signed-off-by: Nir Soffer <nirsof@gmail.com>
@nirs nirs requested review from AkihiroSuda, balajiv113 and jandubois and removed request for balajiv113 November 22, 2024 21:58
This was referenced Nov 22, 2024
- name: "Lima: vm1: iperf3 (host -> vm1)"
run: |
iperf3 -c "$(cat /tmp/vm1_ip)"
iperf3-darwin -c "$(cat /tmp/vm1_ip)"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this solve the macos-15 issue? 👀

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this solves the issue - just another cleanup to unify the way we run host to vm tests, used in test/perf.sh.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I can split the changes to check which change is the fix.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't use this is test/perf.sh - this the way I'm testing manually with vfkit, I need to update test/perf.sh.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job failed without iper3-darwin:
https://github.com/lima-vm/socket_vmnet/actions/runs/11980909877/job/33406141644

Maybe it uses different DNS resolver?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the test doesn't seem relying on DNS?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this must be something else.

By specifying memory and cpus in the vm yaml.

Signed-off-by: Nir Soffer <nirsof@gmail.com>
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants