ci: More test cleanups#84
Merged
Merged
Conversation
nirs
force-pushed
the
ci-plain-mode
branch
3 times, most recently
from
4b91895 to
c625058
Compare
nirs
dismissed
AkihiroSuda’s stale review
The merge-base changed after approval.
Member
GitHub no longer recognizes me as a maintainer 😄 |
nirs
dismissed
AkihiroSuda’s stale review
The merge-base changed after approval.
AkihiroSuda
previously approved these changes
Nov 23, 2024
Since we are testing the latest commit there is no reason to build lima from source. This saves about 5 minutes and removes the go dependency. Signed-off-by: Nir Soffer <nirsof@gmail.com>
This is standard practice and seems to resolve this this failure:
Run limactl shell vm1 sudo DEBIAN_FRONTEND=noninteractive apt-get install -y iperf3
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package iperf3
Signed-off-by: Nir Soffer <nirsof@gmail.com>
We test on very old and slow machines that tends to fail randomly a lot. Lets minimize the test by using the simplest possible vm without any feature. When we have more powerful and stable runners, we can try to test more interesting vms. Signed-off-by: Nir Soffer <nirsof@gmail.com>
nirs
dismissed
AkihiroSuda’s stale review
The merge-base changed after approval.
Member
Author
|
Rebase on master, ready for merge. |
AkihiroSuda
approved these changes
Nov 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.