CI: add macos-15-large by AkihiroSuda · Pull Request #63 · lima-vm/socket_vmnet

AkihiroSuda · 2024-11-04T16:05:10Z

No description provided.

AkihiroSuda · 2024-11-04T16:31:41Z

https://github.com/lima-vm/socket_vmnet/actions/runs/11668029741/job/32487531768?pr=63

▶ Run limactl shell vm1 ip -4 -json addr show dev lima0 | jq -r .[0].addr_info[0].local | tee /tmp/vm1_iP
192.168.105.3

▶ Run iperf3 -c "$(cat /tmp/vm1_ip)"
  
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

jandubois

Thanks, LGTM

AkihiroSuda · 2024-11-04T18:50:15Z

https://github.com/lima-vm/socket_vmnet/actions/runs/11670466432/job/32494724116?pr=63

+ netstat -rn
Routing tables

Internet:
Destination        Gateway            Flags               Netif Expire
default            192.168.64.1       UGScg                 en0       
default            link#11            UCSIg           bridge100      !
127                127.0.0.1          UCS                   lo0       
127.0.0.1          127.0.0.1          UH                    lo0       
169.254            link#5             UCS                   en0      !
192.168.64         link#5             UCS                   en0      !
192.168.64.1/32    link#5             UCS                   en0      !
192.168.64.1       16:9d:99:c7:98:64  UHLWIir               en0   1144
192.168.64.30/32   link#5             UCS                   en0      !
192.168.105        link#11            UC              bridge100      !
192.168.105.2      link#11            UHLWIi          bridge100      !
192.168.105.3      52.55.55.e7.4b.ea  UHLWIi          bridge100   1186
[...]

++ cat /tmp/vm1_ip
+ ping -c 3 192.168.105.3
PING 192.168.105.3 (192.168.105.3): 56 data bytes
64 bytes from 192.168.105.3: icmp_seq=0 ttl=64 time=1.498 ms
64 bytes from 192.168.105.3: icmp_seq=1 ttl=64 time=1.661 ms
64 bytes from 192.168.105.3: icmp_seq=2 ttl=64 time=3.294 ms

--- 192.168.105.3 ping statistics ---
3 packets transmitted, 3 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 1.498/2.151/3.294/0.811 ms
++ cat /tmp/vm1_ip
+ iperf3 -c 192.168.105.3
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

The routing table seems just same as macos-13.

"No route to host" doesn't seem to occur with ping 🤔

The CI is passing for macos-14-large as well as macos-13-large, so something should have changed in macos-15-large.

nirs · 2024-11-07T23:53:02Z

I would split the changes to:

remove macos-12 to ubreak the build
add macos-14 since it works now
add macos-15 later, probably need more work

nirs · 2024-11-22T22:00:16Z

Should work after #83 is merged.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

nirs · 2024-11-23T02:34:36Z

+    name: Integration tests
+    # Only a single version of macOS is used for running integration tests, due to the flakiness of the CI.
+    runs-on: macos-15-large  # Intel (supports nested virtualization)
    timeout-minutes: 40


The build takes 9 minutes now (with #84) - so we can use much smaller timeout now, maybe 15 minutes?

nirs · 2024-11-23T02:36:19Z

-        #
-        # TODO: add macos-15-large https://github.com/lima-vm/socket_vmnet/pull/63
-        platform: [macos-13-large, macos-14-large]
+        platform: [macos-13, macos-14, macos-15]


This build only on aarch64, previously we built only on x86_64. We don't wan to test build on both?

Intel is covered in the integration test

This will be easier to maintain if we use:

platform: - macos-13 - macos-14 - macos-15

nirs · 2024-11-23T02:37:30Z

+    runs-on: macos-15-large  # Intel (supports nested virtualization)
    timeout-minutes: 40
    steps:
      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1


This compiles both for x86_64 and aarch64, but we test only on x86_64 - any reason to build twice when we test the build in the build job?

For testing reproducibility on Intel

OK, makes sense, this is also very quick.

nirs · 2024-11-23T02:40:06Z

+        run: make
+  integration:
+    name: Integration tests
+    # Only a single version of macOS is used for running integration tests, due to the flakiness of the CI.


Good idea but better to add macos-15 and change the build in separate commits.

This change is doing 2 logical changes - adding new plafrom for testing and removing older platform. We can do this separately but it works as is.

nirs

Lets merge, we can always add and remove platforms.

AkihiroSuda added this to the v1.1.8 milestone Nov 4, 2024

AkihiroSuda force-pushed the dev branch from 9c1cce0 to bed0269 Compare November 4, 2024 16:33

jandubois previously approved these changes Nov 4, 2024

View reviewed changes

AkihiroSuda commented Nov 4, 2024

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

AkihiroSuda dismissed jandubois’s stale review via 58aaf63 November 4, 2024 16:55

AkihiroSuda force-pushed the dev branch 2 times, most recently from 58aaf63 to 9dec178 Compare November 4, 2024 17:11

AkihiroSuda mentioned this pull request Nov 4, 2024

CI: remove macos-12 lima-vm/lima#2840

Merged

AkihiroSuda force-pushed the dev branch 2 times, most recently from 4a5044e to 3168f9c Compare November 4, 2024 18:33

AkihiroSuda removed this from the v1.1.8 milestone Nov 8, 2024

AkihiroSuda force-pushed the dev branch 2 times, most recently from 4af81af to ac0ca93 Compare November 21, 2024 00:01

AkihiroSuda marked this pull request as draft November 21, 2024 00:02

AkihiroSuda force-pushed the dev branch 2 times, most recently from 0871f01 to ad667b1 Compare November 21, 2024 14:49

AkihiroSuda changed the title ~~CI: remove macos-12; add macos-15-large~~ CI: add macos-15-large Nov 21, 2024

nirs reviewed Nov 22, 2024

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

CI: add macos-15-large

670aced

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

AkihiroSuda force-pushed the dev branch from ad667b1 to 670aced Compare November 23, 2024 02:22

AkihiroSuda marked this pull request as ready for review November 23, 2024 02:23

AkihiroSuda added this to the v1.2.0 milestone Nov 23, 2024

AkihiroSuda requested a review from nirs November 23, 2024 02:23

nirs reviewed Nov 23, 2024

View reviewed changes

nirs approved these changes Nov 25, 2024

View reviewed changes

jandubois merged commit d929ac7 into lima-vm:master Nov 25, 2024

This was referenced Nov 25, 2024

Prevent homebrew from upgrading QEMU when installing Lima #87

Closed

Revert "CI: add macos-15-large" #88

Merged

nirs mentioned this pull request Nov 26, 2024

Simplify CI #89

Merged

Conversation

AkihiroSuda commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jandubois left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AkihiroSuda commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nirs commented Nov 7, 2024

Uh oh!

Uh oh!

nirs commented Nov 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AkihiroSuda commented Nov 4, 2024 •

edited

Loading

AkihiroSuda commented Nov 4, 2024 •

edited

Loading

AkihiroSuda commented Nov 4, 2024 •

edited

Loading