-
Notifications
You must be signed in to change notification settings - Fork 152
send errors and warnings to stderr #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should help address linode#643, although possibly only in part.
|
Overall looks good to me! |
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for the contribution!
|
Hey @jschauma, thanks for the contribution! Could you run |
|
Sure - ran 'make format'. (I find ending the printf list of arguments with a comma a bit odd, but if that's what the formatter wants...?) |
Thank you! The formatter can make some odd decisions at times but we try to keep things as consistent as possible. |
|
FYI: I marked this PR as a breaking change since it technically could break scripts that check for error outputs in stdout. We'll mention this in the notes for the next release. |
zliang-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@zliang-akamai I've been bitten by the behavior fixed by this PR - all of my VM provisioning fails b/c I get an extra in the json output. Strangely enough version 5.52.0 doesn't fail for me. I will add a workaround on my side, however do yu mind pushing a new release to PyPI which includes this PR? |
This should help address #643, although possibly only in part.