Skip to content

Conversation

@ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Oct 31, 2024

📝 Description

Unit tests have been failing due to error output being routed to stderr instead of stdout introduced by this PR

The reason why it wasn't detected in the workflow in the first place is because our makefile returned status of export command instead of actual exit code of pytest command.
E.g.

.PHONY: testunit
testunit:
	@mkdir -p /tmp/linode/.config
	@orig_xdg_config_home=$${XDG_CONFIG_HOME:-}; \
	export LINODE_CLI_TEST_MODE=1 XDG_CONFIG_HOME=/tmp/linode/.config; \
	pytest -v tests/unit; \
	export XDG_CONFIG_HOME=$$orig_xdg_config_home;

This fix is also in this PR

✔️ How to Test

make testunit

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner October 31, 2024 19:31
@ykim-akamai ykim-akamai requested review from yec-akamai and zliang-akamai and removed request for a team October 31, 2024 19:31
@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Oct 31, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, thank you for fixing this!

@ezilber-akamai ezilber-akamai self-requested a review October 31, 2024 19:52
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing locally for me as well!

@ykim-akamai ykim-akamai merged commit 183646f into linode:dev Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants