Rework clock muxes into a chain structure #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note, this is an early draft. I'd like to discuss the concept before finishing the conversion. This was not validated on the hw, so it can be buggy even for the reworked platforms. |
Merged
MarijnS95
approved these changes
Oct 31, 2023
Contributor
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Sounds like a good idea!
lumag
changed the title
Collaborator
Author
|
@MarijnS95 @konradybcio please review, I think I'm done with the implementation. |
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
reviewed
Nov 6, 2023
MarijnS95
approved these changes
Nov 6, 2023
Contributor
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
I haven't cross-checked every platform change, but the architectural rework and function implementations look fine to me!
Will try to test on a few platforms when I get the chance.
Enforcing a primary+leaf configuration does not walk for all the cases. Some clocks (msm8996 CPU) have more muxes to be powered on. Other (MCCC) do not require GCC at all. Make clock measurement more versatile by reworking GCC + optional leaf into a chain of muxes. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Contributor
|
Quickly tested on |
Member
|
Tested on sm8550, works fine 👍 |
Collaborator
Author
|
My primary testing targets were msm8996 and sm8250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforcing a primary+leaf configuration does not walk for all the cases. Some clocks (msm8996 CPU) have more muxes to be powered on. Other (MCCC) do not require GCC at all. Make clock measurement more versatile by reworking GCC + optional leaf into a chain of muxes.
cc @MarijnS95 @konradybcio-work