Skip to content

Conversation

@superna9999
Copy link
Member

This adds Debugcc support for SM8650

Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM (haven't checked any of the values) though perhaps we should land #24 and #26 first to make this even cleaner?

@superna9999
Copy link
Member Author

@MarijnS95 sure, I'll rebase when both are merged

@superna9999 superna9999 marked this pull request as draft November 7, 2023 09:07
@superna9999 superna9999 force-pushed the sm8650 branch 2 times, most recently from 233f6a5 to ed401b1 Compare November 7, 2023 11:46
@superna9999 superna9999 marked this pull request as ready for review November 7, 2023 11:46
@superna9999 superna9999 requested a review from MarijnS95 November 7, 2023 11:46
Copy link
Collaborator

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, few minor nits.

Add debugcc tables for the SM8650 platform

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
@lumag lumag merged commit e68ff01 into linux-msm:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants