Skip to content

Conversation

@lumag
Copy link
Collaborator

@lumag lumag commented Oct 28, 2023

No description provided.

meson.build Outdated
Comment on lines 47 to 49
command: ['echo',
'/* Autogenerated file, do not edit */\n\n' +
'\n'.join(platform_strings)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me who thinks this is really dirty? I love the idea of autogenerating the file, but we have the string contents in a Meson variable... And have to run that through a shell command to get it into the file?!? Doesn't configure_file() have a file_contents: str sort of argument for this use-case?

Copy link
Contributor

@MarijnS95 MarijnS95 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it actually makes sense to create a platforms.h.in file with the static contents (comment header, static inline for the platforms and use @NAME@ syntax) via meson variables to fill in the contents.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no. I think this is the best way I have for now. Suggestions are appreciated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll see if I can submit a PR with that idea later, if it turns out to work.

@lumag lumag force-pushed the meson branch 2 times, most recently from d0a2731 to e69f306 Compare October 30, 2023 11:49
@lumag lumag requested a review from MarijnS95 October 30, 2023 11:50
lumag added 2 commits November 6, 2023 13:01
Switch to meson as a build system. Define a list of supported platforms
and use it to generate platforms list and the symlink targets.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Add very simple CI setup to check that debugcc builds correctly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
lumag added 2 commits November 6, 2023 13:23
Fix the following error:

../debugcc.c: In function 'mmap_mux':
../debugcc.c:295:40: error: format '%zx' expects argument of type 'size_t', but argument 2 has type 'long unsigned int' [-Werror=format=]

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@konradybcio konradybcio merged commit dd604f9 into linux-msm:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants