Skip to content
This repository was archived by the owner on Mar 24, 2020. It is now read-only.

Update kernel/opengcs/runc#41

Merged
rn merged 6 commits intomasterfrom
update
Mar 18, 2019
Merged

Update kernel/opengcs/runc#41
rn merged 6 commits intomasterfrom
update

Conversation

@rn
Copy link
Copy Markdown
Member

@rn rn commented Mar 17, 2019

resolves #38
resolves #37
resolves #39

I have no means of testing this. @jhowardmsft could you review?

rn added 6 commits March 17, 2019 12:20
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
@lowenna
Copy link
Copy Markdown

lowenna commented Mar 17, 2019

Yes, I can try this out. @rn is there anyway would can put binaries somewhere? I can build initrd from this but I’ve never managed to get a kernel build complete using linuxkit locally.

@rn
Copy link
Copy Markdown
Member Author

rn commented Mar 18, 2019

@lowenna
Copy link
Copy Markdown

lowenna commented Mar 18, 2019

Aha! Thanks. Yes will try when I’m the office tomorrow

@lowenna
Copy link
Copy Markdown

lowenna commented Mar 18, 2019

@rn LGTM. I've run through some basic validation of networking, commit, pull, run, volume, cp, build and it passed fine.

@rn rn merged commit d5dfdbc into master Mar 18, 2019
@rn rn deleted the update branch March 22, 2019 03:53
@Iristyle
Copy link
Copy Markdown

Iristyle commented Apr 4, 2019

About to try building this on Windows, but hopefully linuxkit/linuxkit#3317 fixes the problem I filed in linuxkit/linuxkit#3207 / removes the need for my linuxkit fork.

UPDATE: Confirmed my linuxkit fork is no longer necessary!

@Iristyle
Copy link
Copy Markdown

Iristyle commented Apr 4, 2019

Also @jhowardmsft - not sure if linuxkit/linuxkit#3120 is relevant any longer? It still shows up as a note in this repo, but with kernel being bumped to 4.19.27 it would seem it's no longer a concern.

@justincormack
Copy link
Copy Markdown
Member

@Iristyle in #37 he said not

Iristyle added a commit to Iristyle/lcow that referenced this pull request Apr 4, 2019
 - linuxkit#41 bumped the kernel to 4.19.27, and linuxkit#37 already noted that the
   performance concerns over kernel version (and slow pulls) were no
   longer relevant.

   Therefore, remove the note.
Iristyle added a commit to Iristyle/lcow that referenced this pull request Apr 4, 2019
 - linuxkit#41 bumped the kernel to 4.19.27, and linuxkit#37 already noted that the
   performance concerns over kernel version (and slow pulls) were no
   longer relevant.

   Therefore, remove the note.

Signed-off-by: Iristyle <Iristyle@github>
Iristyle added a commit to Iristyle/lcow that referenced this pull request Apr 4, 2019
 - linuxkit#41 bumped the kernel to 4.19.27, and linuxkit#37 already noted that the
   performance concerns over kernel version (and slow pulls) were no
   longer relevant.

   Therefore, remove the note.

Signed-off-by: Iristyle <Iristyle@github>
@Iristyle
Copy link
Copy Markdown

Iristyle commented Apr 4, 2019

In that case I pushed up #44

Iristyle added a commit to Iristyle/pupperware that referenced this pull request Apr 4, 2019
 - Add some notes about what LCOW 2 requires

 - Update instructions around building a new linuxkit kernel given
   the current binaries are considered outdated based on PR at
   linuxkit/lcow#41

 - Note upgrade to compose 1.24.0

 - Add current version output

 - Remove notes about using Iristyle fork of Linuxkit now that that
   issue is fixed in linuxkit/linuxkit#3317
@lowenna
Copy link
Copy Markdown

lowenna commented Apr 8, 2019

@rn @justincormack Could we get a new release cut based on the artifact above?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(I suspect) the runc vendored in here is pre-recent CVE Microsoft/opengcs is extremely out of date Kernel is extremely out of date

4 participants