add benchmark at bridge and bridge transfer pallet by Marky-Shi · Pull Request #854 · litentry/heima

Marky-Shi · 2022-09-23T03:25:41Z

The issue 794 benchmark update has been completed,and weight files were generated.

…into issue_794

codecov-commenter · 2022-09-23T03:37:53Z

Codecov Report

Merging #854 (75b48f2) into dev (4773438) will increase coverage by 0.41%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #854      +/-   ##
==========================================
+ Coverage   92.12%   92.53%   +0.41%     
==========================================
  Files          28       27       -1     
  Lines        7187     7155      -32     
==========================================
  Hits         6621     6621              
+ Misses        566      534      -32

Impacted Files	Coverage Δ
pallets/bridge-transfer/src/lib.rs	`80.00% <0.00%> (ø)`
pallets/bridge/src/lib.rs	`86.66% <0.00%> (+0.81%)`	⬆️
pallets/parachain-staking/src/lib.rs	`78.59% <ø> (ø)`
pallets/parachain-staking/src/benchmarking.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Kailai-Wang

I believe there're still some basic problems:

weights not used
the runtime weights need benchmarking
both litmus and litentry runtime weights need to be updated

pallets/bridge-transfer/src/lib.rs

…chain into issue_794

…try/litentry-parachain into 855-refactor-benchmark-yml

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

runtime/litmus/src/lib.rs

runtime/litentry/src/lib.rs

Kailai-Wang

I approve it first, however, the weight calculation for acknowledge_proposal is incorrect.

And we should (almost) never modify the generated weights file manually.

I'll create another issue for better readability

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Types import and web3 signature verification for IMP mock (#850) * update rust toolchain for llvm15 * add web3 verification skeleton * implement verification * fix ecdsa verify * clippy fix and comments * minor comment update * debug: relocate migration file (#844) * debug: relocate migration file * debug: change runtime methpd public to private * debug: correct chain spec * debug: correct chain spec Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com> * Add tests for IMP mock (#856) * remove MrenclaveType * use oaep padding * add more testcases * add tests for verifying web3 identities * clippy fix * add cargofix * add GHA for benchmarking machine (#870) * Refactor benchmark yml (#868) * separate docker-build and benchmark * add if condition * remove stop instance for debugging * ssh debug * retry * more debugging * go back to normal routine * use reachability test for AWS instance * fix syntax * Initial VCMP impl (#857) * move tee-related primitives to primitives/ * rename and use ALICE * skeleton of vc-management pallet * add basic tests * minor comment update * add vcmp to runtime * cargo update * cargo update * use cargo pkgid for full-qualified pallet names * add benchmark at bridge and bridge transfer pallet (#854) * Fix some events triggered by token-bridge * fix some syntax * issue 794 add benchmark code * fix benchmark code * fix some syntax * about benchmark code * Chengcheng Shi * fix some syntax * add bridge-transfer weight file * add benchmark code at bridge and bridge transfer pallet * fix some syntax * add benchmark code at litentry and litmus * fix asset manager pallet benchmark code * temporarily chose to comment pallet_collator_selection out * Comment out the pallet_collator_selection module in the toml file * fix parachain-staking benchmark code * fix staking benchmark code * fix staking benchmark code * fix staking benchmark code * fix all benchmarks code * common the staking benchmark code * fix some syntax * commond the staking benchmarks * common staking benchmarks * fix syntax * Temporarily comment out the staking benchmark * Temporarily comment out the staking benchmark * Temporarily comment out the staking benchmark * separate docker-build and benchmark * add if condition * remove stop instance for debugging * ssh debug * retry * more debugging * go back to normal routine * use reachability test for AWS instance * fix syntax * [benchmarking bot] Auto commit generated weights files (#869) Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> * Change the bridge-related weight configuration in runtime * fix bridge benchmark code * [benchmarking bot] Auto commit generated weights files (#875) Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain> Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com> * Issue 871 Wrong weight calculation for acknowledge_proposal (#877) * fix bridge benchmarks code * fix some syntax * [benchmarking bot] Auto commit generated weights files (#878) Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> * Change how weight is calculated * Change the weight * [benchmarking bot] Auto commit generated weights files (#879) Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> * Bump serde_json from 1.0.85 to 1.0.86 (#882) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.85 to 1.0.86. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.85...v1.0.86) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add rococo for local dev (#880) * bug fix about chain identity * add CI/scripts for rococo * add rococo ts-tests * add --allow-fail to benchmark machine Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com> Co-authored-by: SCC <87012234+Jinsipang@users.noreply.github.com> Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain> Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Chengcheng Shi and others added 14 commits September 8, 2022 15:51

Fix some events triggered by token-bridge

541ad35

fix some syntax

283033a

Merge branch 'dev' into fee_transfer

58f5e77

issue 794 add benchmark code

d47e3c5

Merge branch 'dev' of https://github.com/litentry/litentry-parachain …

a44ec99

…into issue_794

fix benchmark code

2236e81

fix some syntax

8dc7eef

about benchmark code

9f19eed

Chengcheng Shi

e4251d4

fix some syntax

3351cb6

add bridge-transfer weight file

28447d1

add benchmark code at bridge and bridge transfer pallet

d5c24ff

Merge branch 'dev' into issue_794

f3dc3a4

fix some syntax

b9a3b00

Kailai-Wang requested changes Sep 23, 2022

View reviewed changes

pallets/bridge-transfer/src/lib.rs Outdated Show resolved Hide resolved

Chengcheng Shi and others added 14 commits September 26, 2022 15:54

add benchmark code at litentry and litmus

307488d

Merge branch 'dev' into issue_794

9b5f860

fix asset manager pallet benchmark code

2739bdd

temporarily chose to comment pallet_collator_selection out

4e59ec6

Comment out the pallet_collator_selection module in the toml file

47a6242

fix parachain-staking benchmark code

6bcd9cf

fix staking benchmark code

3e70b8e

fix staking benchmark code

3ae7583

Merge branch 'dev' into issue_794

0b725f8

fix staking benchmark code

af03ab0

Merge branch 'issue_794' of https://github.com/litentry/litentry-para…

a72fec8

…chain into issue_794

fix all benchmarks code

a49c8f2

common the staking benchmark code

50a35e7

fix some syntax

0a20d00

Chengcheng Shi and others added 17 commits September 30, 2022 23:11

commond the staking benchmarks

8f065bc

common staking benchmarks

53c5e5b

fix syntax

73f6f4a

Temporarily comment out the staking benchmark

0fce347

Temporarily comment out the staking benchmark

8bb2b61

Temporarily comment out the staking benchmark

2888d5c

separate docker-build and benchmark

414ce78

add if condition

4e4b0e4

remove stop instance for debugging

e4b42e4

ssh debug

bf3a8c2

retry

b5287a9

more debugging

22295aa

go back to normal routine

0b8ccb0

use reachability test for AWS instance

4c09e12

fix syntax

e8c154a

Merge branch '855-refactor-benchmark-yml' of https://github.com/liten…

dae252b

…try/litentry-parachain into 855-refactor-benchmark-yml

[benchmarking bot] Auto commit generated weights files (#869)

6f621d9

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Kailai-Wang requested changes Oct 4, 2022

View reviewed changes

runtime/litmus/src/lib.rs Outdated Show resolved Hide resolved

runtime/litmus/src/lib.rs Outdated Show resolved Hide resolved

runtime/litentry/src/lib.rs Show resolved Hide resolved

Change the bridge-related weight configuration in runtime

9cd3cee

Kailai-Wang approved these changes Oct 4, 2022

View reviewed changes

Kailai-Wang and others added 3 commits October 5, 2022 10:55

Merge branch 'dev' into issue_794

854d21a

fix bridge benchmark code

8f970df

[benchmarking bot] Auto commit generated weights files (#875)

75b48f2

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Marky-Shi merged commit c95ce3a into dev Oct 9, 2022

Marky-Shi deleted the issue_794 branch October 10, 2022 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add benchmark at bridge and bridge transfer pallet#854

add benchmark at bridge and bridge transfer pallet#854
Marky-Shi merged 49 commits intodevfrom
issue_794

Marky-Shi commented Sep 23, 2022

Uh oh!

codecov-commenter commented Sep 23, 2022 •

edited

Loading

Uh oh!

Kailai-Wang left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kailai-Wang left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Marky-Shi commented Sep 23, 2022

Uh oh!

codecov-commenter commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Kailai-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kailai-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Sep 23, 2022 •

edited

Loading