Skip to content

Add tests for IMP mock#856

Merged
Kailai-Wang merged 6 commits intodevfrom
848-imp-mock-tests
Sep 27, 2022
Merged

Add tests for IMP mock#856
Kailai-Wang merged 6 commits intodevfrom
848-imp-mock-tests

Conversation

@Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Sep 27, 2022

resolves #848

I used SR25519 pair for substrate testing and eth pair for evm testing. We can add more types if we have time.
This PR also changes the padding scheme to OAEP when encrypting using tee's mock shielding key

@Kailai-Wang Kailai-Wang requested a review from a team September 27, 2022 10:59
@Kailai-Wang Kailai-Wang self-assigned this Sep 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #856 (70bed47) into dev (8057f9b) will increase coverage by 1.98%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##              dev     #856      +/-   ##
==========================================
+ Coverage   90.14%   92.12%   +1.98%     
==========================================
  Files          24       25       +1     
  Lines        7030     7071      +41     
==========================================
+ Hits         6337     6514     +177     
+ Misses        693      557     -136
Impacted Files Coverage Δ
pallets/identity-management-mock/src/lib.rs 57.08% <72.72%> (+57.08%) ⬆️
pallets/identity-management-mock/src/key.rs 100.00% <100.00%> (ø)
pallets/identity-management-mock/src/tests.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

BillyWooo
BillyWooo approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile
clippyfix:
SKIP_WASM_BUILD=1 cargo clippy --fix --workspace --all-targets --all-features -- -D warnings

.PHONY: cargofix ## cargo clippy --fix
Copy link
Collaborator

@BillyWooo BillyWooo Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the make help menu, both have the same comment. a bit confusing. But not a big issue.

Copy link
Collaborator Author

@Kailai-Wang Kailai-Wang Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the make help menu, both have the same comment. a bit confusing. But not a big issue.

Thanks, will correct it in next PR

@Kailai-Wang Kailai-Wang merged commit 64c6943 into dev Sep 27, 2022
@Kailai-Wang Kailai-Wang deleted the 848-imp-mock-tests branch September 27, 2022 19:39
wangminqi added a commit that referenced this pull request Oct 11, 2022
@wangminqi @Kailai-Wang
@Marky-Shi @github-actions @dependabot
update branch weight 1.5 (#883)
982a876 
* Types import and web3 signature verification for IMP mock (#850)

* update rust toolchain for llvm15

* add web3 verification skeleton

* implement verification

* fix ecdsa verify

* clippy fix and comments

* minor comment update

* debug: relocate migration file (#844)

* debug: relocate migration file

* debug: change runtime methpd
public to private

* debug: correct chain spec

* debug: correct chain spec

Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>

* Add tests for IMP mock (#856)

* remove MrenclaveType

* use oaep padding

* add more testcases

* add tests for verifying web3 identities

* clippy fix

* add cargofix

* add GHA for benchmarking machine (#870)

* Refactor benchmark yml (#868)

* separate docker-build and benchmark

* add if condition

* remove stop instance for debugging

* ssh debug

* retry

* more debugging

* go back to normal routine

* use reachability test for AWS instance

* fix syntax

* Initial VCMP impl (#857)

* move tee-related primitives to primitives/

* rename and use ALICE

* skeleton of vc-management pallet

* add basic tests

* minor comment update

* add vcmp to runtime

* cargo update

* cargo update

* use cargo pkgid for full-qualified pallet names

* add benchmark at bridge and bridge transfer pallet (#854)

* Fix some events triggered by token-bridge

* fix some syntax

* issue 794 add benchmark code

* fix benchmark code

* fix some syntax

* about benchmark code

* Chengcheng Shi

* fix some syntax

* add bridge-transfer weight file

* add benchmark code at bridge and bridge transfer pallet

* fix some syntax

* add benchmark code at litentry and litmus

* fix asset manager pallet benchmark code

* temporarily chose to comment pallet_collator_selection out

* Comment out the pallet_collator_selection module in the toml file

* fix parachain-staking benchmark code

* fix staking benchmark code

* fix staking benchmark code

* fix staking benchmark code

* fix all benchmarks code

* common the staking benchmark code

* fix some syntax

* commond the staking benchmarks

* common staking benchmarks

* fix syntax

* Temporarily comment out the staking benchmark

* Temporarily comment out the staking benchmark

* Temporarily comment out the staking benchmark

* separate docker-build and benchmark

* add if condition

* remove stop instance for debugging

* ssh debug

* retry

* more debugging

* go back to normal routine

* use reachability test for AWS instance

* fix syntax

* [benchmarking bot] Auto commit generated weights files (#869)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Change the bridge-related weight configuration in runtime

* fix bridge benchmark code

* [benchmarking bot] Auto commit generated weights files (#875)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>
Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>

* Issue 871 Wrong weight calculation for acknowledge_proposal (#877)

* fix bridge benchmarks code

* fix some syntax

* [benchmarking bot] Auto commit generated weights files (#878)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Change how weight is calculated

* Change the weight

* [benchmarking bot] Auto commit generated weights files (#879)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Bump serde_json from 1.0.85 to 1.0.86 (#882)

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.85 to 1.0.86.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.85...v1.0.86)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add rococo for local dev (#880)

* bug fix about chain identity

* add CI/scripts for rococo

* add rococo ts-tests

* add --allow-fail to benchmark machine

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>
Co-authored-by: SCC <87012234+Jinsipang@users.noreply.github.com>
Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyWooo BillyWooo BillyWooo approved these changes

Assignees

@Kailai-Wang Kailai-Wang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests for IMP mock

3 participants

@Kailai-Wang @codecov-commenter @BillyWooo