Hold lock on all ffi events #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1740cfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1egoman
approved these changes
Dec 4, 2025
packages/livekit-rtc/src/room.ts
Outdated
| console.warn(`RoomEvent.TrackUnpublished: Could not find publication`); | ||
| } | ||
| } else if (ev.case == 'trackSubscribed') { | ||
| console.info('ffi track subscribed event received'); |
Contributor
There was a problem hiding this comment.
nitpick: Was this log intended to be left here or was this only for debugging?
Contributor
Author
There was a problem hiding this comment.
forgot to push up the commit that removed this, thanks for catching that!
davidzhao
added a commit
that referenced
this pull request
Jan 2, 2026
* hold lock on all ffi events * Create cool-peaches-flash.md * remove debug log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for reviewing, enable "hide whitespace" in the review tab.
changes are minimal, but due to indentation levels changing the diff appears quite large.