Skip to content

Hold lock on all ffi events #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 4 commits into from
Dec 4, 2025
Merged

Hold lock on all ffi events #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c527dd8
hold lock on all ffi events
lukasIO Dec 4, 2025
760ae7d
Create cool-peaches-flash.md
lukasIO Dec 4, 2025
a718413
remove debug log
lukasIO Dec 4, 2025
1740cfc
Merge branch 'lukas/debug-bun' of github.com:livekit/node-sdks into l…
lukasIO Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-peaches-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/rtc-node": patch
---

Hold lock on all ffi events
10 changes: 5 additions & 5 deletions packages/livekit-rtc/src/participant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,13 @@ export type DataPublishOptions = {
export class LocalParticipant extends Participant {
private rpcHandlers: Map<string, (data: RpcInvocationData) => Promise<string>> = new Map();

private roomEventLock: Mutex;
private ffiEventLock: Mutex;

trackPublications: Map<string, LocalTrackPublication> = new Map();

constructor(info: OwnedParticipant, roomEventLock: Mutex) {
constructor(info: OwnedParticipant, ffiEventLock: Mutex) {
super(info);
this.roomEventLock = roomEventLock;
this.ffiEventLock = ffiEventLock;
}

async publishData(data: Uint8Array, options: DataPublishOptions) {
Expand Down Expand Up @@ -662,7 +662,7 @@ export class LocalParticipant extends Participant {
options: options,
});

const unlock = await this.roomEventLock.lock();
const unlock = await this.ffiEventLock.lock();

const res = FfiClient.instance.request<PublishTrackResponse>({
message: { case: 'publishTrack', value: req },
Expand Down Expand Up @@ -690,7 +690,7 @@ export class LocalParticipant extends Participant {
}

async unpublishTrack(trackSid: string, stopOnUnpublish?: boolean) {
const unlock = await this.roomEventLock.lock();
const unlock = await this.ffiEventLock.lock();
try {
const req = new UnpublishTrackRequest({
localParticipantHandle: this.ffi_handle.handle,
Expand Down
Loading
Loading