Conversation
gardner48
requested review from
balos1,
cswoodward and
drreynolds
as code owners
balos1
left a comment
balos1
left a comment
There was a problem hiding this comment.
One minor change request, otherwise this looks great.
| .. versionadded:: 6.1.0 | ||
|
|
||
|
|
||
| .. c:function:: int ARKodeGetNumRhsEvals(void* arkode_mem, int num_rhs, long int* num_rhs_evals) |
There was a problem hiding this comment.
While this unifies all the RHS eval getter, the num_rhs argument is still closely tied to the type of stepper. Each stepper already "knows" it's number of RHS' and how many values to write to num_rhs_evals, so in that sense the argument is not needed. Unfortunately, it is needed for validation but still doesn't guarantee num_rhs_evals has sufficient storage.
I'd like to pitch what I think is a somewhat cleaner option:
int ARKodeGetNumRhsEvals(void* arkode_mem, int partition_idx, long int* num_rhs_evals)
This writes a single number to num_rhs_evals corresponding to the evals for partition partition_idx. If partition_idx<0 that can be the total across all RHS'. This is essentially what I did for counting evolves in operator splitting:
There was a problem hiding this comment.
I think this sounds good and is a bit cleaner. @drreynolds what do you think?
There was a problem hiding this comment.
I'm good with either approach.
Steven-Roberts
left a comment
Steven-Roberts
left a comment
There was a problem hiding this comment.
One minor comment but otherwise looks good.
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
Add an ARKODE level function to get the number of RHS evaluations --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: Steven Roberts <roberts115@llnl.gov>
4 participants
Add an ARKODE level function to get the number of RHS evaluations