Skip to content

Conversation

@millnut
Copy link
Member

@millnut millnut commented Aug 14, 2025

What does this change?

Fixes #879 the following error on the workflow tests

1) Drupal\Tests\localgov\Functional\LocalGovUpdateTest::testUpdate
There should be no errors in configuration 'core.entity_view_display.geo_entity.address.default'. Errors:
Schema key core.entity_view_display.geo_entity.address.default:content.location.settings.leaflet_markercluster.excluded failed with: missing schema

Failed asserting that Array &0 (
    'core.entity_view_display.geo_entity.address.default:content.location.settings.leaflet_markercluster.excluded' => 'missing schema'
) is true.

and then following errors, e.g.

Failed asserting that Array &0 (
    'core.entity_view_display.localgov_geo.address.default:content.location.settings.leaflet_markercluster.excluded' => 'missing schema'
) is true.

Failed asserting that Array &0 (
    'views.view.localgov_directory_channel:display.embed_map.display_options.style.options.view_mode' => 'missing schema'
) is true.

@millnut millnut changed the title fix: failing phpunit test fix: [3.2.x] failing phpunit test Aug 14, 2025
@millnut millnut marked this pull request as ready for review August 14, 2025 16:40
@millnut millnut marked this pull request as draft August 16, 2025 15:21
@tonypaulbarker
Copy link
Contributor

Hi @millnut this one is marked as 'draft'. Is more work needed here or could we include it in the next release #884 ?

@millnut
Copy link
Member Author

millnut commented Sep 8, 2025

Hi @tonypaulbarker I just need to do some cleanup, I'll get it ready later today

@millnut
Copy link
Member Author

millnut commented Sep 8, 2025

Hi @tonypaulbarker this is now ready for review

@millnut millnut marked this pull request as ready for review September 8, 2025 19:00
@tonypaulbarker
Copy link
Contributor

Thanks @millnut will give it a look :)

Copy link
Contributor

@tonypaulbarker tonypaulbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We have applied the changes to 3.x here #881

@finnlewis finnlewis merged commit 52dbaf7 into 3.2.x Sep 9, 2025
12 of 13 checks passed
@finnlewis finnlewis deleted the fix/3.2.x/fix-failing-test branch September 9, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants