Add internal logger and tests #11
Conversation
Rakefile
Outdated
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| task :default => :spec | ||
| task default: :spec |
There was a problem hiding this comment.
changed by Rubocop
lib/logdna/resources.rb
Outdated
| MS_IN_A_DAY = 86400000 | ||
| MAX_REQUEST_TIMEOUT = 300000 | ||
| MAX_LINE_LENGTH = 32000 | ||
| LOG_LEVELS = %w[DEBUG INFO WARN ERROR FATAL TRACE].freeze |
There was a problem hiding this comment.
changed by rubocop. I am not sure which one reads better
| end | ||
|
|
||
| # Should retry to connect and preserve the failed line | ||
| def fatal_method_not_found(level, port, expected_level) |
There was a problem hiding this comment.
I decided not pass the parameter for repetition number (how many times to call the method and with which values for each time) bc I think it will be less readable.
dchai76
left a comment
dchai76
left a comment
There was a problem hiding this comment.
Ugh, the rubocop-initiated changes make this harder to review. They should arguably have been in a separate PR, but whatever.
One request - it's nicer for your reviewers if you avoid all the temp commits with meaningless titles and squash them with a descriptive summary before you push your changes to remote. It just makes things easier to follow.
dchai76
left a comment
dchai76
left a comment
There was a problem hiding this comment.
Let's leave the CircleCI changes for a separate PR - otherwise looks good.
Besides rebasing, there are 2 things that
|
vilyapilya
force-pushed
the
add-internal-logger
branch
from
9d4025e to
f4fb072
Compare
Adds internal logger instead of "puts"
Adds tests for all methods and unsuccessful request.