Remove the git dependecy from gemspec file #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchai76
reviewed
Nov 19, 2019
logdna.gemspec
Outdated
| spec.files = `git ls-files -z`.split("\x0").reject do |f| | ||
| f.match(%r{^(test|spec|features)/}) | ||
| end | ||
| spec.files = Dir.glob("{lib}/**/*") + %w(LICENSE.txt README.md) |
Contributor
There was a problem hiding this comment.
The idea behind the PR is reasonable but isn't this too broad?
Contributor
Author
There was a problem hiding this comment.
I'll pull out the #11 changes from here. No, I don't thin the files selection is broad. It includes only the functional files. And I included the .md and .txt files because this is what people seems to do for ruby gems. Although, I don't see why they include them.
vilyapilya
force-pushed
the
gemSpecChange
branch
from
e5139f3 to
427862e
Compare
smusali
changed the title
Contributor
|
@vilyapilya, whatever this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gemspec file successfully builds the gemspec but it is better not to depend on git while building gem. Besides the way it was filtering the files did not work and the gemspec contained unnecessary files.
And I included minites to the dev dep in gemspec since I am using it. (Added in the previous PR)