In CircleCI, when linting with Rubocop, don't autocorrect #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
@dchai76, it's already included in #15 by @vilyapilya - I think, we can close this one |
vilyapilya
approved these changes
Dec 21, 2019
Contributor
vilyapilya
left a comment
vilyapilya
left a comment
There was a problem hiding this comment.
@smusali let's keep this PR since it isolates the change unlike mine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're calling
rubocopwith-awhich autocorrects lint errors (that can be autocorrected). That's not what we want to do - we want to report them.Before: master passes CircleCI
After: it fails due to failing lint checks. The lint checks were failing before, but CircleCI was passing because they were autocorrected.